If getting the current directory fails because of encoding conversion

Thu Aug 14 17:58:23 2003  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkfilesel.c (get_current_dir_utf8): If getting
        the current directory fails because of encoding
        conversion problems, walk up textually to parent
        directories until we can convert. (#113627)

diff --git a/ChangeLog b/ChangeLog
index 8eb6493aba7c40a25b7910718472d0dc990a7805..9e99c52e96e6931a20d9882f398db67f326079ab 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+Thu Aug 14 17:58:23 2003  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkfilesel.c (get_current_dir_utf8): If getting
+       the current directory fails because of encoding
+       conversion problems, walk up textually to parent
+       directories until we can convert. (#113627)
+
 Wed Aug 13 17:01:49 2003  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkmenushell.[ch] (gtk_menu_shell_enter_notify):

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 8eb6493aba7c40a25b7910718472d0dc990a7805..9e99c52e96e6931a20d9882f398db67f326079ab 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+Thu Aug 14 17:58:23 2003  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkfilesel.c (get_current_dir_utf8): If getting
+       the current directory fails because of encoding
+       conversion problems, walk up textually to parent
+       directories until we can convert. (#113627)
+
 Wed Aug 13 17:01:49 2003  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkmenushell.[ch] (gtk_menu_shell_enter_notify):

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 8eb6493aba7c40a25b7910718472d0dc990a7805..9e99c52e96e6931a20d9882f398db67f326079ab 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,10 @@
+Thu Aug 14 17:58:23 2003  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkfilesel.c (get_current_dir_utf8): If getting
+       the current directory fails because of encoding
+       conversion problems, walk up textually to parent
+       directories until we can convert. (#113627)
+
 Wed Aug 13 17:01:49 2003  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkmenushell.[ch] (gtk_menu_shell_enter_notify):

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 8eb6493aba7c40a25b7910718472d0dc990a7805..9e99c52e96e6931a20d9882f398db67f326079ab 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+Thu Aug 14 17:58:23 2003  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkfilesel.c (get_current_dir_utf8): If getting
+       the current directory fails because of encoding
+       conversion problems, walk up textually to parent
+       directories until we can convert. (#113627)
+
 Wed Aug 13 17:01:49 2003  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkmenushell.[ch] (gtk_menu_shell_enter_notify):

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 8eb6493aba7c40a25b7910718472d0dc990a7805..9e99c52e96e6931a20d9882f398db67f326079ab 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+Thu Aug 14 17:58:23 2003  Owen Taylor  <otaylor@redhat.com>
+
+       * gtk/gtkfilesel.c (get_current_dir_utf8): If getting
+       the current directory fails because of encoding
+       conversion problems, walk up textually to parent
+       directories until we can convert. (#113627)
+
 Wed Aug 13 17:01:49 2003  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkmenushell.[ch] (gtk_menu_shell_enter_notify):

diff --git a/gtk/gtkfilesel.c b/gtk/gtkfilesel.c
index 8f47a76b1ffee901e25be5d57b6ae4afeceac774..006de18cd7245db7eda389aa31ff6687d209d4bd 100644 (file)
--- a/gtk/gtkfilesel.c
+++ b/gtk/gtkfilesel.c
@@ -2605,19 +2605,55 @@ cmpl_is_a_completion (PossibleCompletion* pc)
 /*                      Construction, deletion                       */
 /**********************************************************************/
 
+/* Get the nearest parent of the current directory for which
+ * we can convert the filename into UTF-8. With paranoia.
+ * Returns "." when all goes wrong.
+ */
+static gchar *
+get_current_dir_utf8 (void)
+{
+  gchar *dir = g_get_current_dir ();
+  gchar *dir_utf8 = NULL;
+
+  while (TRUE)
+    {
+      gchar *last_slash;
+
+      dir_utf8 = g_filename_to_utf8 (dir, -1, NULL, NULL, NULL);
+      if (dir_utf8)
+       break;
+
+      last_slash = strrchr (dir, G_DIR_SEPARATOR);
+      if (!last_slash)         /* g_get_current_dir() wasn't absolute! */
+       break;
+
+      if (last_slash + 1 == g_path_skip_root (dir)) /* Parent directory is a root directory */
+       {
+         if (last_slash[1] == '\0') /* Root misencoded! */
+           break;
+         else
+           last_slash[1] = '\0';
+       }
+      else
+       last_slash[0] = '\0';
+      
+      g_assert (last_slash);
+    }
+
+  g_free (dir);
+  
+  return dir_utf8 ? dir_utf8 : g_strdup (".");
+}
+
 static CompletionState*
 cmpl_init_state (void)
 {
-  gchar *sys_getcwd_buf;
   gchar *utf8_cwd;
   CompletionState *new_state;
 
   new_state = g_new (CompletionState, 1);
 
-  /* g_get_current_dir() returns a string in the "system" charset */
-  sys_getcwd_buf = g_get_current_dir ();
-  utf8_cwd = g_filename_to_utf8 (sys_getcwd_buf, -1, NULL, NULL, NULL);
-  g_free (sys_getcwd_buf);
+  utf8_cwd = get_current_dir_utf8 ();
 
 tryagain:
 
@@ -2912,10 +2948,7 @@ open_ref_dir (gchar           *text_to_complete,
       else
        {
          /* If no possible candidates, use the cwd */
-         gchar *sys_curdir = g_get_current_dir ();
-         gchar *utf8_curdir = g_filename_to_utf8 (sys_curdir, -1, NULL, NULL, NULL);
-
-         g_free (sys_curdir);
+         gchar *utf8_curdir = get_current_dir_utf8 ();
 
          new_dir = open_dir (utf8_curdir, cmpl_state);